Problemas na codificação do meu app

  • Respostas:0
Bento Luiz
  • Posts no fórum: 1

11/07/2013, 08:14:18 via Web

Estou desenvolvendo um app para controle dos meus medicamentos, gostaria de pedir pra alguém com mais experiência verificar meu código e ver o que eu posso melhorar pra não ficar tão "gambiarra".

package com.example.calendarcontrol;

import android.app.Activity;
import android.media.MediaPlayer;
import android.os.Bundle;
import android.util.Log;
import android.view.View;
import android.widget.Button;

public class julho extends Activity {

MediaPlayer mp;
boolean marcar = true;
Button[] bt;
int i = 0;

@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.julho);
inicializacaoObjetosMenuPrincipal();
listenersMenuPrincipal();
}

public void inicializacaoObjetosMenuPrincipal() {

try {

bt = new Button[31];
bt[0] = (Button) findViewById(R.id.bt1);
bt[1] = (Button) findViewById(R.id.bt2);
bt[2] = (Button) findViewById(R.id.bt3);
bt[3] = (Button) findViewById(R.id.bt4);
bt[4] = (Button) findViewById(R.id.bt5);
bt[5] = (Button) findViewById(R.id.bt6);
bt[6] = (Button) findViewById(R.id.bt7);
bt[7] = (Button) findViewById(R.id.bt8);
bt[8] = (Button) findViewById(R.id.bt9);
bt[9] = (Button) findViewById(R.id.bt10);
bt[10] = (Button) findViewById(R.id.bt11);
bt[11] = (Button) findViewById(R.id.bt12);
bt[12] = (Button) findViewById(R.id.bt13);
bt[13] = (Button) findViewById(R.id.bt14);
bt[14] = (Button) findViewById(R.id.bt15);
bt[15] = (Button) findViewById(R.id.bt16);
bt[16] = (Button) findViewById(R.id.bt17);
bt[17] = (Button) findViewById(R.id.bt18);
bt[18] = (Button) findViewById(R.id.bt19);
bt[19] = (Button) findViewById(R.id.bt20);
bt[20] = (Button) findViewById(R.id.bt21);
bt[21] = (Button) findViewById(R.id.bt22);
bt[22] = (Button) findViewById(R.id.bt23);
bt[23] = (Button) findViewById(R.id.bt24);
bt[24] = (Button) findViewById(R.id.bt25);
bt[25] = (Button) findViewById(R.id.bt26);
bt[26] = (Button) findViewById(R.id.bt27);
bt[27] = (Button) findViewById(R.id.bt28);
bt[28] = (Button) findViewById(R.id.bt29);
bt[29] = (Button) findViewById(R.id.bt30);
bt[30] = (Button) findViewById(R.id.bt31);

} catch (Exception erro) {
Log.e("Erro em inicializacaoObjetosMenuPrincipal",
erro.getMessage());
}
}

public void change(int i) {
if (marcar == false) {
bt[i].setBackgroundResource(0);
marcar = true;
} else {
bt[i].setBackgroundResource(R.drawable.ix);
marcar = false;
}
}

public void listenersMenuPrincipal() {

try {

for (; i < bt.length; i++) {
switch (bt[i].getId()) {
case R.id.bt1:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(0);
}
});

break;

case R.id.bt2:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(1);
}
});

break;

case R.id.bt3:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(2);
}
});

break;
case R.id.bt4:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(3);
}
});

break;
case R.id.bt5:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(4);
}
});

break;
case R.id.bt6:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(5);
}
});

break;
case R.id.bt7:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(6);
}
});

break;
case R.id.bt8:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(7);
}
});

break;
case R.id.bt9:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(8);
}
});

break;
case R.id.bt10:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(9);
}
});

break;
case R.id.bt11:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(10);
}
});

break;

case R.id.bt12:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(11);
}
});

break;

case R.id.bt13:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(12);
}
});

break;

case R.id.bt14:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(13);
}
});

break;

case R.id.bt15:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(14);
}
});

break;

case R.id.bt16:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(15);
}
});

break;

case R.id.bt17:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(16);
}
});

break;

case R.id.bt18:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(17);
}
});

break;
case R.id.bt19:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(18);
}
});

break;

case R.id.bt20:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(19);
}
});

break;

case R.id.bt21:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(20);
}
});

break;

case R.id.bt22:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(21);
}
});

break;

case R.id.bt23:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(22);
}
});

break;

case R.id.bt24:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(23);
}
});

break;

case R.id.bt25:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(24);
}
});

break;

case R.id.bt26:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(25);
}
});

break;

case R.id.bt27:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(26);
}
});

break;

case R.id.bt28:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(27);
}
});

break;
case R.id.bt29:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(28);
}
});

break;
case R.id.bt30:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(29);
}
});

break;
case R.id.bt31:
bt[i].setOnClickListener(new View.OnClickListener() {

@Override
public void onClick(View v) {
change(30);
}
});

break;

}

}

} catch (Exception e) {
Log.d("Erro em Listeners Menu Principal", e.getMessage());
}
}

}

Responder